Improve error message when using an invalid object key #1193
Conversation
Fixes #516 * Changed the error string to include the immediate outer object, key type and value. * Fix the shadowing of variable v by the function called by Iter so object can be printed. Signed-off-by: repenno <rapenno@gmail.com>
There was a problem hiding this comment.
This may improve debuggability a bit, however, there are two things that come to mind...
-
Including values computed during evaluation inside of error messages can be risky. We don't want secret values operated on inside of the policy to accidentally leak out into error messages or logs.
-
Errors generated deep into the call stack will still be hard to locate.
I think what I'd rather see here is an improvement to the evaluator to return errors with the source location where the error occurred (e.g., the expression location.)
|
I don't know if the scope is increased considerably, the change is likely localized to the place where the error is generated in eval.go but we'd need to investigate first. If you want to just link to my comment in the above issue, that would be fine. It would be better not to merge this because of the two issues mentioned above. |
Fixes #516
type and value.
object can be printed.
Signed-off-by: repenno rapenno@gmail.com